[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <11025.1178877817@redhat.com>
Date: Fri, 11 May 2007 11:03:37 +0100
From: David Howells <dhowells@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page()
Andrew Morton <akpm@...ux-foundation.org> wrote:
> Yes, it's a shame that there doesn't seem to be a fine-grained way of
> turning on -W's useful bits.
You can turn off -W's undesirable bits. For net/rxrpc/ and fs/afs/ at least,
adding:
CFLAGS += -W -Wno-unused-parameter
to the Makefile generates no warnings. Perhaps this should be added to the
master Makefile.
Adding -Wsign-compare finds some stuff that I will fix. It also finds some
stuff in the main and the networking headers. This is a really useful option
and found some tricky bugs in CacheFiles. I would endorse adding this
generally too.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists