linux-kernel - Re: [-mm patch] make csum_and_copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070511170443.GF26112@flint.arm.linux.org.uk>
Date:	Fri, 11 May 2007 18:04:43 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Frederik Deweerdt <deweerdt@...e.fr>
Cc:	David Miller <davem@...emloft.net>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [-mm patch] make csum_and_copy_from_user arch independent

On Fri, May 11, 2007 at 03:56:18PM +0200, Frederik Deweerdt wrote:
> On Fri, May 11, 2007 at 02:14:43AM -0700, David Miller wrote:
> > From: Frederik Deweerdt <deweerdt@...e.fr>
> > Date: Fri, 11 May 2007 10:27:38 +0200
> > 
> > > ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
> > > 
> > > Linking on ARM fails because albeit a generic csum_and_copy_from_user()
> > > function is provided in the case ! _HAVE_ARCH_COPY_AND_CSUM_FROM_USER, the
> > > generic function uses csum_partial_copy_from_user() which is i386 only.
> > 
> > On what planet is csum_partial_copy_from_user() i386 only?
> > Every single platform provides that function.
> Er, my bad, I've changed my cscope bindings and I saw no results except
> i386.
> > The issue more-so appears to be that ARM simply fails to
> > export the symbol to modules like the other platforms do.
> Indeed, here's the fix.

Could you mail it to me in the conventional format (iow, with a
proper subject line and description) please?

> Thanks,
> Frederik
> 
> Signed-off-by: Frederik Deweerdt <frederik.deweerdt@...il.com>
> 
> diff --git a/arch/arm/kernel/armksyms.c b/arch/arm/kernel/armksyms.c
> index 4779f47..9179e82 100644
> --- a/arch/arm/kernel/armksyms.c
> +++ b/arch/arm/kernel/armksyms.c
> @@ -76,6 +76,7 @@ EXPORT_SYMBOL(__const_udelay);
>  
>  	/* networking */
>  EXPORT_SYMBOL(csum_partial);
> +EXPORT_SYMBOL(csum_partial_copy_from_user);
>  EXPORT_SYMBOL(csum_partial_copy_nocheck);
>  EXPORT_SYMBOL(__csum_ipv6_magic);
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/