[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4644D11C.2040207@goop.org>
Date: Fri, 11 May 2007 13:25:00 -0700
From: Jeremy Fitzhardinge <jeremy@...p.org>
To: Roland McGrath <roland@...hat.com>
CC: Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
virtualization@...ts.osdl.org, lkml <linux-kernel@...r.kernel.org>,
Chris Wright <chrisw@...s-sol.org>,
Xen-devel <xen-devel@...ts.xensource.com>,
Ian Pratt <ian.pratt@...source.com>,
Christian Limpach <Christian.Limpach@...cam.ac.uk>,
Zachary Amsden <zach@...are.com>,
Ulrich Drepper <drepper@...hat.com>
Subject: Re: [patch 02/28]xen: Add nosegneg capability to the vsyscall page
notes
Roland McGrath wrote:
>> + * It should contain:
>> + * hwcap 0 nosegneg
>> + * to match the mapping of bit to name that we give here.
>>
>
> This comment still needs s/0/1/ to match the code. Given that the actual
> bit is now defined in the macro in another file, perhaps the comment should
> say more about it than just a magic 1.
>
Crap, I thought I had 1) understood it, and 2) fixed it. I guess I
skipped 1 and therefore overlooked 2.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists