linux-kernel - Re: slub-i386-support.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070511075410.GT19966@holomorphy.com>
Date:	Fri, 11 May 2007 00:54:10 -0700
From:	William Lee Irwin III <wli@...omorphy.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andi Kleen <ak@...e.de>, Hugh Dickins <hugh@...itas.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Lameter <clameter@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: slub-i386-support.patch

At some point in the past, Hugh Dickins wrote:
>>> I'm guessing (haven't rechecked source) that the cpu_idle() call comes
>>> about because the top level pgd of a process gets freed very late in
>>> its exit, and after a great flurry of processes have just exited,
>>> perhaps there was nothing to free up the accumulation.  Though
>>> it still strikes me as an odd place to do it.

On Fri, 11 May 2007 10:29:30 +0200 Andi Kleen <ak@...e.de> wrote:
>> I always found it odd and probably the wrong place too.

On Fri, May 11, 2007 at 12:42:00AM -0700, Andrew Morton wrote:
> so... what's the bottom line here, guys?  Should we change that patch?

My summary:
(1) The patch is safe-as is, though it should move its hook elsewhere.
(2) Scribbling on the memory still irks me but is safe.
(3) I should redo the i386 pgd updates to suck less.
(4) Christoph might let me change quicklists to use struct page pointers.

For (3) I can post the update any time; it won't conflict with the
quicklist code, apart from textually, and I can handle the mergework.
The case one should hold off on merging the quicklist code is if
Christoph wants to update the core quicklist code or have me update
it according to the cached precomputed value scheme I outlined in a
prior post before its initial merge. I'll prepare all the patches for
comment regardless.

-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/