linux-kernel - Re: undefined "pm3fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1178978268.4773.14.camel@daplas>
Date:	Sat, 12 May 2007 21:57:48 +0800
From:	"Antonino A. Daplas" <adaplas@...il.com>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: undefined "pm3fb_setup()"

On Sat, 2007-05-12 at 06:32 -0400, Robert P. J. Day wrote:
>   i'm guessing someone's already spotted this but, with "make
> allyesconfig" on x86:
> 
> ...
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `pm3fb_init':
> drivers/video/pm3fb.c:977: undefined reference to `pm3fb_setup'
> ...
> 
>   the reason seems to be this excerpt from drivers/video/pm3fb.c:
> 
> ================================================================
> int __init pm3fb_init(void)
> {
>         /*
>          *  For kernel boot options (in 'video=pm3fb:<options>' format)
>          */
> #ifndef MODULE                       <-----------------------
>         char *option = NULL;
> 
>         if (fb_get_options("pm3fb", &option))
>                 return -ENODEV;
>         pm3fb_setup(option);
> #endif
> 
>         return pci_register_driver(&pm3fb_driver);
> }
> 
> static void __exit pm3fb_exit(void)
> {
>         pci_unregister_driver(&pm3fb_driver);
> }
> 
> #ifdef MODULE  

I've spotted this before, but forgotten about it.  Yes, the above should
be #ifndef

Tony


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/