linux-kernel - Re: [PATCH 1/2] non-string based tsc unstable reasons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705122056.42926.ak@suse.de>
Date:	Sat, 12 May 2007 20:56:42 +0200
From:	Andi Kleen <ak@...e.de>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	johnstul@...ibm.com, mingo@...e.hu
Subject: Re: [PATCH 1/2] non-string based tsc unstable reasons

On Saturday 12 May 2007 17:43:45 Daniel Walker wrote:
> Just passing a string to mark_tsc_unstable() doesn't allow real code to change
> based on the reason for the instablility. I changed mark_tsc_unstable()
> to accept a string and a flag which denotes a general reason why the tsc
> is unstable, and can be evaluated in code.
> 
> This is based off John Stultz patch to add the string reasons.

This seems ugly -- it would be better to just do whatever needs to
be doing in the caller instead of passing down a enum and then switch.

And why do you really need it anyways?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/