linux-kernel - Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070513161353.GB29024@redhat.com>
Date:	Sun, 13 May 2007 12:13:53 -0400
From:	Dave Jones <davej@...hat.com>
To:	Tejun Heo <htejun@...il.com>
Cc:	Jeff Garzik <jeff@...zik.org>,
	William Thompson <wt@...ctro-mechanical.com>,
	Mark Lord <liml@....ca>, linux-kernel@...r.kernel.org,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	albertcc@...ibm.com
Subject: Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2

On Sun, May 13, 2007 at 02:57:44PM +0200, Tejun Heo wrote:
 > Jeff Garzik wrote:
 > > Tejun Heo wrote:
 > >> +            if (class == ATA_DEV_ATA)
 > >> +                class = ATA_DEV_ATAPI;
 > >> +            else
 > >> +                class = ATA_DEV_ATA;
 > > 
 > > 
 > > the 'else' branch is obviously redundant
 > 
 > Why?  We can also fallback from ATAPI to ATA.

Then did you mean to write..

+            if (class == ATA_DEV_ATA)
+                class = ATA_DEV_ATAPI;
+            else if (class == ATA_DEV_ATAPI)
+                class = ATA_DEV_ATA;

?

Otherwise, as Jeff mentions, you're doing a redundant assignment
in the else branch.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/