linux-kernel - Re: [PATCH] Fix UCB1x00 driver to use sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070514092109.GJ11735@elf.ucw.cz>
Date:	Mon, 14 May 2007 11:21:09 +0200
From:	Pavel Machek <pavel@....cz>
To:	Satoru Takeuchi <takeuchi_satoru@...fujitsu.com>
Cc:	tglx@...utronix.de, Linux Kernel <linux-kernel@...r.kernel.org>,
	Russell King <rmk@....linux.org.uk>
Subject: Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler

Hi!

> > > Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
> > > ===================================================================
> > > --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c	2007-05-11 18:53:36.000000000 +0900
> > > +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c	2007-05-11 19:33:20.000000000 +0900
> > > @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
> > >  	 * We could run as a real-time thread.  However, thus far
> > >  	 * this doesn't seem to be necessary.
> > >  	 */
> > > -//	tsk->policy = SCHED_FIFO;
> > > -//	tsk->rt_priority = 1;
> > > +//	struct sched_param param = { .sched_priority = 1 };
> > > +//
> > > +//	sched_setscheduler(tsk, SCHED_FIFO, &param);
> > 
> > Can we please remove the unused code completely instead of replacing it
> > by more commented out code ?
> 
> It's OK to me, but I'm not the driver writer and doesn't know how important
> are those comments. If removing them is better for driver writers too, here
> is the patch.

I doubt anyone cares either way. Feel free to add my ACK to either
"remove" or "fix" version.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/