linux-kernel - Re: why does x86 "make defconfig" build a single, lonely module?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0705140235h6a96563cw63ed2c7a85a4f736@mail.gmail.com>
Date:	Mon, 14 May 2007 15:05:16 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"James Bottomley" <James.Bottomley@...eleye.com>
Cc:	"Dave Jones" <davej@...hat.com>,
	"Robert P. J. Day" <rpjday@...dspring.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org
Subject: Re: why does x86 "make defconfig" build a single, lonely module?

Hi,

On 5/13/07, James Bottomley <James.Bottomley@...eleye.com> wrote:
> On Sun, 2007-05-13 at 11:10 -0500, James Bottomley wrote:
> > > -   depends on SCSI
> > > +   depends on SCSI_SCAN_ASYNC

This is incorrect, alright, but not because of any of the reasons James
mentions below.

The only reason why some module (or Kconfig option) should _depend_
on some other Kconfig option is if (*and only if*) it re-uses _code_
exported by said dependency.

In this particular case, SCSI_SCAN_ASYNC=y/n only controls the
default value of some variable somewhere in SCSI, so no other code
can meaningfully "depend" on it.

> > No.  SCSI_SCAN_ASYNC is a bool ... if you depend on it, you'll force the
> > wait scan to be built in, which isn't the idea at all.

Umm, this isn't true, actually.

> Plus SCSI_SCAN_ASYNC only sets the *default* for async scanning.  You
> can alter this at boot time, so you could need the wait scan module even
> with it set to N.

I think the _correct_ way to handle this situation (and which would make
everyone happy here; Robert can get his module-free builds with defconfig,
James gets his SCSI_WAIT_SCAN module even if nobody asked for it
explicitly) would be as follows:

---

Clean up Kconfig entry for CONFIG_SCSI_WAIT_SCAN.

Signed-off-by: Satyam Sharma <satyam.sharma@...il.com>

---

 drivers/scsi/Kconfig |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

---

diff -ruNp a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
--- a/drivers/scsi/Kconfig	2007-05-10 23:19:32.000000000 +0530
+++ b/drivers/scsi/Kconfig	2007-05-14 15:12:46.000000000 +0530
@@ -243,9 +243,8 @@ config SCSI_SCAN_ASYNC

 config SCSI_WAIT_SCAN
 	tristate
-	default m
-	depends on SCSI
-	depends on MODULES
+	default m if SCSI=m
+	default n

 menu "SCSI Transports"
 	depends on SCSI
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/