linux-kernel - Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4648BC93.8080909@sun.com>
Date:	Mon, 14 May 2007 12:46:27 -0700
From:	Yinghai Lu <Yinghai.Lu@....COM>
To:	Yinghai Lu <Yinghai.Lu@....COM>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...e.de>, bjorn.helgaas@...com,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: set RTS and DTR if flow is 'r'  --- resend

Russell King wrote:
> Still wrong, and unfortunately you haven't understood what I was saying
> at all because this is worse. ;(
>
> Do not put the code in serial8250_set_termios.  It is the wrong place.
>   

I don't want to put that there. the problem is serial8250_set_mctrl 
called by will clear DTR bit.

uart_set_options==>serial8250_set_termios ==> serial8250_set_mctrl will 
clear DTR bit

YH


static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
{
struct uart_8250_port *up = (struct uart_8250_port *)port;
unsigned char mcr = 0;

if (mctrl & TIOCM_RTS)
mcr |= UART_MCR_RTS;
if (mctrl & TIOCM_DTR)
mcr |= UART_MCR_DTR;
if (mctrl & TIOCM_OUT1)
mcr |= UART_MCR_OUT1;
if (mctrl & TIOCM_OUT2)
mcr |= UART_MCR_OUT2;
if (mctrl & TIOCM_LOOP)
mcr |= UART_MCR_LOOP;

mcr = (mcr & up->mcr_mask) | up->mcr_force | up->mcr;

serial_out(up, UART_MCR, mcr);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/