linux-kernel - Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070514142125.851f3d10.akpm@linux-foundation.org>
Date:	Mon, 14 May 2007 14:21:25 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Vitaly Bordug <vitb@...nel.crashing.org>
Cc:	linux-pcmcia@...ts.infradead.org, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

On Wed, 09 May 2007 02:31:25 +0400
Vitaly Bordug <vitb@...nel.crashing.org> wrote:

> +/* 
> + * Some internal interrupt registers use an 8-bit mask for the interrupt
> + * level instead of a number.
> + */
> +static inline uint mk_int_int_mask(uint mask) {
> +	return (1 << (7 - (mask/2)));
> +}

grumble.  "uint" isn't a favoured "type".  Please prefer to
use "unsigned int" if that's what is meant.  Or maybe u32,
if that's more appropriate - and it probably is, as we're
dealing with device registers here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/