linux-kernel - Re: [PATCH 2/5] lguest guest feedback tidyups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1179126709.23513.194.camel@localhost.localdomain>
Date:	Mon, 14 May 2007 17:11:49 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Al Viro <viro@....linux.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	virtualization <virtualization@...ts.linux-foundation.org>,
	Jeff Garzik <jeff@...zik.org>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH 2/5] lguest guest feedback tidyups

On Sun, 2007-05-13 at 19:43 +0100, Al Viro wrote:
> On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote:
> >  	/* Devices are in page above top of "normal" mem. */
> > -	lguest_devices = ioremap(max_pfn << PAGE_SHIFT, PAGE_SIZE);
> > +	lguest_devices = (__force void*)ioremap(max_pfn<<PAGE_SHIFT,PAGE_SIZE);
> 
> Er...  What's being done here?  What are we mapping and what's going to
> be accessed when we dereference that sucker?

This, too, is now wrapped in lguest_map() in the updated patch.  

Guest virtual device memory can be directly accessed, but Jeff Garzik
and Christoph Hellwig made good points about not encouraging such
abnormal use of ioremap in drivers.

BTW, I've done a new rollup patch of lguest against 2.6.21, if you would
like to review the whole thing.  This version includes the big code
documentation patch not yet in -mm.

	http://lguest.ozlabs.org/lguest-2.6.21-290.patch.gz

Thanks,
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/