linux-kernel - Re: [patch i2o 1/6] i2o_cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070515174251.2e49ae71@the-village.bc.nu>
Date:	Tue, 15 May 2007 17:42:51 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Vasily Averin <vvs@...ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	devel@...nvz.org, Markus Lidel <Markus.Lidel@...dowconnect.com>
Subject: Re: [patch i2o 1/6] i2o_cfg_passthru cleanup

> -      cleanup:
> +cleanup:
>  	kfree(reply);
> +	if (msg)
> +out:
> +		i2o_msg_nop(c, msg);

Put the label before the if. Much saner that way


>  	kfree(reply);
> +	if (msg)
> +out:
> +		i2o_msg_nop(c, msg);
>  	return rcode;

Ditto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/