linux-kernel - Re: Linux 2.6.22-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 May 2007 08:50:34 +1000
From:	"andrew hendry" <andrew.hendry@...il.com>
To:	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.22-rc1

Yes, putting the extern highstart_pfn back compiles clean for that rand config.

Sorry for the attachment, no access to a patch friendly mailer at work.

Andrew.

On 5/16/07, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
>
> On Tue, 15 May 2007, andrew hendry wrote:
> >
> > almost, highstart_pfn is used in a few printks
> >
> > arch/i386/mm/discontig.c: In function 'setup_memory':
> > arch/i386/mm/discontig.c:314: error: 'highstart_pfn' undeclared (first
> > use in this function)
> > arch/i386/mm/discontig.c:314: error: (Each undeclared identifier is
> > reported only once
> > arch/i386/mm/discontig.c:314: error: for each function it appears in.)
>
> Gaah. highstart_pfn is declared in <asm/highmem.h>, but that one is
> protected by a
>
>         #ifdef CONFIG_HIGHMEM
>         #include <asm/highmem.h>
>
> in <linux/highmem.h>, so even though we include highmem.h, we never see
> the declaration.
>
> Your config is insane, but anyway, does it compile if you just add back
> the extra "unnecessary" declaration of highstart_pfn?
>
>                 Linus
>

View attachment "himem.patch" of type "text/x-patch" (1274 bytes)