linux-kernel - Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070516162459.GD30166@redhat.com>
Date:	Wed, 16 May 2007 12:24:59 -0400
From:	Dave Jones <davej@...hat.com>
To:	Joshua Hoblitt <jhoblitt@....hawaii.edu>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

<dropping trivial@ from cc: as this definitly isn't>

On Tue, May 15, 2007 at 03:17:11PM -1000, Joshua Hoblitt wrote:
 
 > --- linux-2.6.21.1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig    2007-04-27 11:49:26.000000000 -1000
 > +++ linux-2.6.21.1/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-05-15 14:48:50.000000000 -1000
 > @@ -82,6 +82,7 @@ config X86_POWERNOW_K8
 >         tristate "AMD Opteron/Athlon64 PowerNow!"
 >         select CPU_FREQ_TABLE
 >         depends on EXPERIMENTAL
 > +       depends on X86_ACPI_CPUFREQ
 >         help
 >           This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors.

This is completely the wrong thing to do.
There's no dependancy between these two modules, as they are two independant
cpufreq drivers.  I think you may be confused with X86_POWERNOW_K8_ACPI
(Which should get set if you have ACPI_PROCESSOR enabled)

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/