| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <464A8DF5.2010903@yahoo.com.au> Date: Wed, 16 May 2007 14:52:05 +1000 From: Nick Piggin <nickpiggin@...oo.com.au> To: Christoph Lameter <clameter@....com> CC: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Satyam Sharma <satyam.sharma@...il.com>, Nate Diller <nate.diller@...il.com> Subject: Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user Christoph Lameter wrote: > On Tue, 15 May 2007, Andrew Morton wrote: > > >>> The functions above default to KM_USER0 which is also always used when >>> zero_user_page was called except in one single case. We open code that >>> single case to draw attention to the spot. >>> >> >>Dunno. fwiw, we decided to _not_ embed KM_USER0 in the callee: we have had >>some pretty ghastly bugs in the past due to misuse of kmap slots so the >>idea was to shove the decision into the caller's face, make them think >>about what they're doing > > > On the other hand non highmem platforms are burdened with always repeating > the same KM_USER0 in every function call. Isnt it enough to know that > standard functions use KM_USER0 for their operations? Couldn't that be filtered out inline? -- SUSE Labs, Novell Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists