linux-kernel - Re: [PATCH] ide.c: microscopic size and readability optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 May 2007 14:33:54 +0300
From:	Paul Sokolovsky <pmiscml@...il.com>
To:	Borislav Petkov <bbpetkov@...oo.de>
CC:	bzolnier@...il.com, linux-ide@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ide.c: microscopic size and readability optimization

Hello Borislav,

Thursday, May 17, 2007, 2:25:54 PM, you wrote:

> -----
> From: bbpetkov@...oo.de

> A very small size (object file 432 bytes smaller) and readability optimization of ide.c

        And how these "optimizations" fit with BUG_ON() purpose - to
be able to easily identify cause and place of the failure? You
could just remove them altogether and claim that you did even "better"
"optimization".

> Signed-off-by: Borislav Petkov <bbpetkov@...oo.de>

> --
> Index: 22-rc1/drivers/ide/ide.c
> ===================================================================
> --- 22-rc1/drivers/ide/ide.c.orig
> +++ 22-rc1/drivers/ide/ide.c
> @@ -568,10 +568,8 @@ void ide_unregister(unsigned int index)
>         ide_hwgroup_t *hwgroup;
>         int irq_count = 0, unit;

> -       BUG_ON(index >= MAX_HWIFS);
> +       BUG_ON(index >= MAX_HWIFS || in_interrupt() || irqs_disabled());

> -       BUG_ON(in_interrupt());
> -       BUG_ON(irqs_disabled());
>         down(&ide_cfg_sem);



-- 
Best regards,
 Paul                            mailto:pmiscml@...il.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/