linux-kernel - Re: [PATCH] INPUT: Sanitize PIT locking in pcspkr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 May 2007 10:36:36 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Thomas Gleixner" <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Stable Team" <stable@...nel.org>, "Greg KH" <greg@...ah.com>,
	"Andrew Morton" <akpm@...l.org>, "Andi Kleen" <ak@...e.de>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Ralf Baechle" <ralf@...ux-mips.org>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	"Richard Henderson" <rth@...ddle.net>
Subject: Re: [PATCH] INPUT: Sanitize PIT locking in pcspkr

On 5/17/07, Thomas Gleixner <tglx@...utronix.de> wrote:
> Dmitry,
>
> On Thu, 2007-05-17 at 10:15 -0400, Dmitry Torokhov wrote:
> > Hi Thomas,
> >
> > > +#include <asm/i8253.h>
> >
> > I don't see this file in include/asm-i386 and your patch only creates
> > asm-x86_64...
>
> [tglx@...ell4 linux-2.6.21]$ ls include/asm-i386/i82*
> include/asm-i386/i8253.h  include/asm-i386/i8259.h
>

Yes, indeed. I wonder how did I manage not to see it...

> > BTW, is there any reason 8253pit.h can't be used...?
>
> The i386 lock is already exported in i8253.h

Right, since we do have i8253.h on i386 that question does not make sense.

>
> > Hmm... The best way IMO woudl be if arch code attached spinlock that
> > should be used by pcspkr driver to pcspkr platform device (as
> > platform_data) and we would not have private lock at all.
>
> Sounds ugly, but that's not material for now and cannot be applied to
> older kernels, which need this fix as well.
>

But then the driver code does not care about arch details which is nice IMHO.

> BTW, there are more creative PIT users in drivers/input which use the
> global lock already, but the PIT usage there is definitely broken on
> anything >= 2.6.21.
>

Are you talking about drivers/input/joystick/analog.c? What is broken there?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/