linux-kernel - Re: [PATCH] uselib: add missing MNT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a36005b50705170914i17bd853bj638f5098c4e7d788@mail.gmail.com>
Date:	Thu, 17 May 2007 09:14:06 -0700
From:	"Ulrich Drepper" <drepper@...il.com>
To:	"Christoph Hellwig" <hch@....de>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uselib: add missing MNT_NOEXEC check

On 5/17/07, Christoph Hellwig <hch@....de> wrote:
> We don't allow loading ELF shared library from noexec points so the
> same should apply to sys_uselib aswell.

Correct.  But...

>         error = -EINVAL;
> +       if (nd.mnt->mnt_flags & MNT_NOEXEC)
> +               goto exit;

... the error here should be EACCES.  Aside from that you get an ACK from me.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/