linux-kernel - patch jfs-fix-race-waking-up-jfsio-kernel-thread.patch queued to 2.6.21-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200705170154.l4H1sO07018316@sous-sol.org>
Date:	Wed, 16 May 2007 18:54:23 -0700
From:	chrisw@...s-sol.org
To:	shaggy@...ux.vnet.ibm.com, chrisw@...s-sol.org,
	linux-kernel@...r.kernel.org
Cc:	stable@...nel.org
Subject: patch jfs-fix-race-waking-up-jfsio-kernel-thread.patch queued to 2.6.21-stable tree


This is a note to let you know that we have just queued up the patch titled

     Subject: JFS: Fix race waking up jfsIO kernel thread

to the 2.6.21-stable tree.  Its filename is

     jfs-fix-race-waking-up-jfsio-kernel-thread.patch

A git repo of this tree can be found at 
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary


>From stable-bounces@...ux.kernel.org  Tue May 15 20:55:43 2007
From: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To: stable@...nel.org
Date: Tue, 15 May 2007 22:53:36 -0500
Message-Id: <1179287616.8339.8.camel@...ikamp.austin.ibm.com>
Cc: linux-kernel <linux-kernel@...r.kernel.org>
Subject: JFS: Fix race waking up jfsIO kernel thread

It's possible for a journal I/O request to be added to the log_redrive
queue and the jfsIO thread to be awakened after the thread releases
log_redrive_lock but before it sets its state to TASK_INTERRUPTIBLE.

The jfsIO thread should set the state before giving up the spinlock, so
the waking thread will really wake it.

Signed-off-by: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Signed-off-by: Chris Wright <chrisw@...s-sol.org>
---
 fs/jfs/jfs_logmgr.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.21.1.orig/fs/jfs/jfs_logmgr.c
+++ linux-2.6.21.1/fs/jfs/jfs_logmgr.c
@@ -2354,12 +2354,13 @@ int jfsIOWait(void *arg)
 			lbmStartIO(bp);
 			spin_lock_irq(&log_redrive_lock);
 		}
-		spin_unlock_irq(&log_redrive_lock);
 
 		if (freezing(current)) {
+			spin_unlock_irq(&log_redrive_lock);
 			refrigerator();
 		} else {
 			set_current_state(TASK_INTERRUPTIBLE);
+			spin_unlock_irq(&log_redrive_lock);
 			schedule();
 			current->state = TASK_RUNNING;
 		}


Patches currently in stable-queue which might be from shaggy@...ux.vnet.ibm.com are

queue-2.6.21/jfs-fix-race-waking-up-jfsio-kernel-thread.patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/