[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070517182340.GA25691@redhat.com>
Date: Thu, 17 May 2007 14:23:40 -0400
From: Dave Jones <davej@...hat.com>
To: Len Brown <lenb@...nel.org>
Cc: Daniel Drake <dsd@...too.org>, duaneg@...da.com,
prakash@...noor.de, jhoblitt@....hawaii.edu,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powernow-k8: depend on acpi-processor for SMP systems
On Thu, May 17, 2007 at 02:13:42PM -0400, Len Brown wrote:
> > Index: linux/arch/i386/kernel/cpu/cpufreq/Kconfig
> > ===================================================================
> > --- linux.orig/arch/i386/kernel/cpu/cpufreq/Kconfig
> > +++ linux/arch/i386/kernel/cpu/cpufreq/Kconfig
> > @@ -81,6 +81,7 @@ config X86_POWERNOW_K7_ACPI
> > config X86_POWERNOW_K8
> > tristate "AMD Opteron/Athlon64 PowerNow!"
> > select CPU_FREQ_TABLE
> > + select ACPI_PROCESSOR if SMP
> > depends on EXPERIMENTAL
> > help
> > This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors.
>
> Unfortunately this patch will not actually enable ACPI_PROCESSOR in
> the SMP=y ACPI=n case. "select" doesn't work for targets that
> have dependencies.
I don't think we can fix this perfectly tbh, but the above at
least gets us close for the majority of users.
Are there many x86-64 users that don't enable acpi ?
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists