linux-kernel - Re: [PATCH] sata_nv: fix fallout of devres conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <464CFA22.1090600@garzik.org>
Date:	Thu, 17 May 2007 20:58:10 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Tejun Heo <htejun@...il.com>
CC:	Peer Chen <pchen@...dia.com>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org,
	IDE/ATA development list <linux-ide@...r.kernel.org>
Subject: Re: [PATCH] sata_nv: fix fallout of devres conversion

Tejun Heo wrote:
> As with all other drivers, sata_nv's hpriv is allocated with
> devm_kzalloc() and there's no need to free it explicitly.  Kill
> nv_remove_one() which incorrectly used kfree() instead of devm_kfree()
> and use ata_pci_remove_one() directly.
> 
> Original fix is from Peer Chen.
> 
> Signed-off-by: Tejun Heo <htejun@...il.com>
> Cc: Peer Chen <pchen@...dia.com>
> ---
> 
> I think it's prettier this way.  :-)

applied

you forgot diffstat :)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/