linux-kernel - Re: [PATCH 1/1] Misc: phantom, move to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070518140314.4cabb926.akpm@linux-foundation.org>
Date:	Fri, 18 May 2007 14:03:14 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] Misc: phantom, move to unlocked_ioctl

On Fri, 18 May 2007 22:34:53 +0200 (CEST)
Jiri Slaby <jirislaby@...il.com> wrote:

> @@ -118,7 +125,9 @@ static int phantom_ioctl(struct inode *inode, struct file *file, u_int cmd,
>  		if (r.reg > 7)
>  			return -EINVAL;
>  
> +		spin_lock(&dev->ioctl_lock);
>  		r.value = ioread32(dev->iaddr + r.reg);
> +		spin_unlock(&dev->ioctl_lock);

What is that locking protecting in here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/