linux-kernel - Re: [PATCH 01/14] kbuild: make modpost section warnings clearer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0705180851200.3231@yvahk01.tjqt.qr>
Date:	Fri, 18 May 2007 08:52:31 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Sam Ravnborg <sam@...nborg.org>
cc:	LKML <linux-kernel@...r.kernel.org>, linux-arch@...r.kernel.org,
	Russell King <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH 01/14] kbuild: make modpost section warnings clearer


On May 18 2007 08:49, Sam Ravnborg wrote:
>index 113dc77..acd28ab 100644
>--- a/scripts/mod/modpost.c
>+++ b/scripts/mod/modpost.c
>@@ -885,29 +885,28 @@ static void warn_sec_mismatch(const char *modname, const char *fromsec,
> 		return;
> 
> 	if (before && after) {
>-		warn("%s - Section mismatch: reference to %s:%s from %s "
>-		     "between '%s' (at offset 0x%llx) and '%s'\n",
>-		     modname, secname, refsymname, fromsec,
>+		warn("%s(%s+0x%llx): Section mismatch: reference to %s:%s "
>+		     "(between '%s' and '%s')\n",
>+		     modname, fromsec, (long long)r.r_offset,
>+		     secname, refsymname,

%x always takes unsigned. %llx => (unsigned long long)r.r_offset.
Ditto below.

> 		     elf->strtab + before->st_name,
>-		     (long long)r.r_offset,
> 		     elf->strtab + after->st_name);
> 	} else if (before) {
>-		warn("%s - Section mismatch: reference to %s:%s from %s "
>-		     "after '%s' (at offset 0x%llx)\n",
>-		     modname, secname, refsymname, fromsec,
>-		     elf->strtab + before->st_name,
>-		     (long long)r.r_offset);
>+		warn("%s(%s+0x%llx): Section mismatch: reference to %s:%s "
>+		     "(after '%s')\n",
>+		     modname, fromsec, (long long)r.r_offset,
>+		     secname, refsymname,
>+		     elf->strtab + before->st_name);
[more occurences]


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/