linux-kernel - Re: [PATCH] fix kmalloc(0) in arch/ia64/pci/pci.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070518094857.572e804e.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 18 May 2007 09:48:57 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org,
	tony.luck@...el.com
Subject: Re: [PATCH] fix kmalloc(0) in arch/ia64/pci/pci.c

On Thu, 17 May 2007 12:19:59 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > +	if (!windows)
> > +		goto out2;
> >  	controller->window = kmalloc_node(sizeof(*controller->window) * windows,
> >  			GFP_KERNEL, controller->node);
> >  	if (!controller->window)
> > 
> 
> This is a significant change in functionality.  Can you please explain why
> it doesn't break things?
> 
Sorry for long RTT. I found no problem on my machine, but....
I realized I misunderstood how kmalloc(0) works....sorry, please drop patch.

I'll ask a pci guy to fix this.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/