linux-kernel - Re: [PATCH] ubi: kill homegrown endian macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <464D4E91.1000000@yandex.ru>
Date:	Fri, 18 May 2007 09:58:25 +0300
From:	Artem Bityutskiy <dedekind@...dex.ru>
To:	Al Viro <viro@....linux.org.uk>
CC:	Andrew Morton <akpm@...ux-foundation.org>, dedekind@...radead.org,
	linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] ubi: kill homegrown endian macros

Al Viro wrote:
> BTW, you can simply typedef __be16 ubi16_t; etc. and define conversion
> functions as cpu_to_ubi16(x) being (__force ubi16_t)cpu_to_be16(x), etc.
> 
> sparse will do all checks just fine, you still have bitwise operations
> (might or might be not relevant in your case) and for gcc it simply
> becomes __be16, etc - i.e. an integer type.

Err, what is the benefit of it? If we relied on sparce, why not would we be
just using __be16 directly?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/