linux-kernel - Re: [PATCH] Fix/add raw1394 CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705200155.26825.arnd@arndb.de>
Date:	Sun, 20 May 2007 01:55:25 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Petr Vandrovec <petr@...drovec.name>
Cc:	dan@...nedy.org, stefanr@...6.in-berlin.de,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

On Monday 07 May 2007, Petr Vandrovec wrote:
> +struct raw1394_cycle_timer32 {
> +        __u32 cycle_timer;
> +        __u64 local_time;
> +} __attribute__((packed));

Note that this data structure only needs conversion on x86_64 and ia64, but
not on powerpc and other 64 bit architectures that align __u64 also in
32 bit mode.

I would suggest you introduce a new __compat_u64 type as

typedef __u64 __compat_u64 __attribute__((aligned(4)));

in include/asm-{x86_64,ia64}/compat.h and as

typdef __u64 __compat_u64;

in the other architectures. Other people have hit the same problem
before and found varying workarounds, but I think we should just
do it correctly now.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/