linux-kernel - something strange in libata-core.c for kernel 2.6.22-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705201434380.30264@Phoenix.oltrelinux.com>
Date:	Sun, 20 May 2007 14:40:23 +0200 (CEST)
From:	l.genoni@...relinux.com
To:	Alan Cox <alan@...rguk.ukuu.org.uk>, htejun@...il.com
cc:	l.genoni@...relinux.com, linux-kernel@...r.kernel.org
Subject:  something strange in libata-core.c for kernel 2.6.22-rc3


Mybe I am wrong, but if you are detecting 40-wire cable to set them to 
DMA/33, why the check includes also 80-wire cables configuring them to 
DMA/33 too?

With this patch my nvidia4 IDE controllers detects correctly and configure 
correctly DMA/100 for my HD and DMA/33 for my DVD (the first uses a 
80-wire cable, the second a 40-wire cable).

Am I wrong somewhere?

--- libata-core.c.orig  2007-05-20 14:31:25.000000000 +0200
+++ libata-core.c       2007-05-20 14:34:01.000000000 +0200
@@ -3901,8 +3901,7 @@
                 /* UDMA/44 or higher would be available */
                 if((ap->cbl == ATA_CBL_PATA40) ||
                     (ata_drive_40wire(dev->id) &&
-                    (ap->cbl == ATA_CBL_PATA_UNK ||
-                     ap->cbl == ATA_CBL_PATA80))) {
+                    (ap->cbl == ATA_CBL_PATA_UNK))) {
                         ata_dev_printk(dev, KERN_WARNING,
                                  "limited to UDMA/33 due to 40-wire cable\n");
                         xfer_mask &= ~(0xF8 << ATA_SHIFT_UDMA);

regards

Luigi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/