lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 May 2007 06:34:01 +0530 From: "Satyam Sharma" <satyam.sharma@...il.com> To: "Stefan Richter" <stefanr@...6.in-berlin.de> Cc: "Andrew Morton" <akpm@...ux-foundation.org>, "Sam Ravnborg" <sam@...nborg.org>, LKML <linux-kernel@...r.kernel.org>, "Roman Zippel" <zippel@...ux-m68k.org>, "Kumar Gala" <galak@...nel.crashing.org>, "Simon Horman" <horms@...ge.net.au>, "Adrian Bunk" <bunk@...sta.de> Subject: Re: RFC: kconfig select warnings bogus? On 5/20/07, Satyam Sharma <satyam.sharma@...il.com> wrote: > On 5/20/07, Stefan Richter <stefanr@...6.in-berlin.de> wrote: > > Satyam Sharma wrote: > > > A combined patch for all of those on top of 22-rc2 (adding Signed-off-by's > > > for original authors too): > > > > > > Signed-off-by: Kumar Gala <galak@...nel.crashing.org> > > > Signed-off-by: Simon Horman <horms@...ge.net.au> > > > Signed-off-by: Satyam Sharma <ssatyam@....iitk.ac.in> > > > > [...] > > > > Adrian already commented on this. Let me just add that these above > > changes are in so far *totally wrong* as they remove the "depends on > > XYZ" which is implied by "select XYZ". > > Did you even try this patch? > > Did you try to select UCC_GETH and see if UCC_FAST got > automatically selected or not? > > Did you get any build problems (or bogus warnings, for that matter)? > > Have you ever looked into arch/.../Kconfig's? > > > Remember, "select" is like "depends on", just with the added twist that > > the 'make snafuconfig' scripts are instructed to (a) not hide the > > depending option from the user and (b) try to enable the dependency for > > the user if he tries to enable the depending option. > > This is precisely what happens with this patch too. > > Believe me, just go ahead and try it. > > Report any errors, dissatisfaction, etc, if any. > > Thanks. [ Just to add: ] You'll learn about the "default .. if .." Kconfig idiom after you try this, but when this patch works for you, an Acked-by would also be nice, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists