linux-kernel - Re: [PATCH] Extract common MODULE_INFO content into new moduleinfo.h.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.0.99.0705200934580.30819@chino.kir.corp.google.com>
Date:	Sun, 20 May 2007 09:38:26 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] Extract common MODULE_INFO content into new
 moduleinfo.h.

On Sun, 20 May 2007, Robert P. J. Day wrote:

> i can do that as long as there's no way that those changes can (even
> theoretically) make a difference in the build.  in order to make sure
> this patch didn't break anything, i went with a straight cut-and-paste
> of the content to go into the new moduleinfo.h.
> 

__attribute_used__ is pointless outside of function definitions so the way 
it is currently written is incorrect.

> so while i agree that those changes shouldn't hurt, personally, i'd
> prefer to just put this patch through as is and come back later to do
> any tidying related to attribute rewording.
> 

__attribute_used__ is deprecated so it would be helpful to change it now 
instead of requiring a second patch.  It's better if new patches no longer 
use a deprecated attribute.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/