linux-kernel - Re: [PATCH] drivers/ata: Add the SW NCQ support to sata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <465007FD.2060807@dunaweb.hu>
Date:	Sun, 20 May 2007 10:34:05 +0200
From:	Zoltan Boszormenyi <zboszor@...aweb.hu>
To:	Peer Chen <pchen@...dia.com>
Cc:	Jeff Garzik <jeff@...zik.org>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Robert Hancock <hancockr@...w.ca>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

Hi,

Jeff Garzik írta:
> Alan Cox wrote:
>>> That shouldn't be a problem, libata default DMA mask is 32 bits 
>>> (which isn't overridden with this controller) and so the block layer 
>>> will bounce any data being read/written above that point with IOMMU 
>>> or swiotlb. The comment is a bit unnecessarily scary.
>>
>> Adding a BUG_ON for this would be wise. Its trivial to check and a BUG
>> rather than corruption if this assumption ever changes would be far
>> preferable
>
> The default DMA mask -everywhere- is 32 bits.
>
> A lot of code will break if this assumption ever changes, not just 
> libata.
>
>     Jeff

thanks for clarifying this.

I tested the effect of this patch on 2.6.22-rc2 + CFS-v13
with the current CVS version of PostgreSQL 8.3devel.
pgbench with 25 clients and some large number of
transactions to make the result stable showed substantial
increase in throughput. Without NCQ, I got around 446 tps,
with NCQ I got around 680 via local TCP connection.
Previously, I got this level of performance only over
local unix socket and smaller number of simultaneous clients.
The disk is Seagate 320GB (ST3320620AS).

Again, thanks for this patch.

Best regards,
Zoltán Böszörményi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/