linux-kernel - Re: [PATCH 2/2] sysfs: fix race condition around sd->s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4651C589.2060106@gmail.com>
Date:	Mon, 21 May 2007 18:15:05 +0200
From:	Tejun Heo <htejun@...il.com>
To:	Eric Sandeen <sandeen@...hat.com>
CC:	maneesh@...ibm.com, Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Clemens Schwaighofer <cs@...uila.co.jp>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Chuck Ebbert <cebbert@...hat.com>
Subject: Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Eric Sandeen wrote:
> Maneesh Soni wrote:
> 
>> Looks ok to me.. I have tested it it but unfortunately I couldn't
>> recreate the race without the patch also. It would be helpful if
>> people actually seeing the race, provide the test results.
>>
>> Greg, please merge this one once we have some test results.
> 
> I merged this back to RHEL4-era (2.6.9) kernels due to a report of this
> problem on RHEL4.  The tester could hit the sysfs_d_iput bug fairly
> easily before, and has not seen it with this patch in place.
> 
> The other bug they were seeing even more often was the sysfs_readdir()
> oops as we try to extract the inode number for regular sysfs files,
> again due to transient vnodes.  Is any fix for that problem being
> considered for -stable?  I had backported a simpler version of Tejun's
> s_ino fix for the problem, without the ida complexity - and brought a
> couple other small upstream fixes back to support that.  If nothing has
> yet been proposed for -stable, I can post that here.

I don't think any other fix has been proposed yet.  Please post them.
That definitely needs fixing.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/