linux-kernel - Re: bug in 2.6.22-rc2: loop mount limited to one single iso image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c0942db0705210935r72cf076ap946c4f215a61ee5f@mail.gmail.com>
Date:	Mon, 21 May 2007 09:35:12 -0700
From:	"Ray Lee" <ray-lk@...rabbit.org>
To:	"Ken Chen" <kenchen@...gle.com>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Kay Sievers" <kay.sievers@...y.org>,
	"Al Viro" <viro@....linux.org.uk>,
	"Andrey Borzenkov" <arvidjaar@...l.ru>,
	"Uwe Bugla" <uwe.bugla@....de>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Michal Piotrowski" <michal.k.k.piotrowski@...il.com>
Subject: Re: bug in 2.6.22-rc2: loop mount limited to one single iso image

On 5/21/07, Ken Chen <kenchen@...gle.com> wrote:
> On 5/21/07, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> > I don't have much choice. I assume it is
> >
> >    commit 73285082 "remove artificial software max_loop limit"
> >
> > that introduced the new behaviour. Ken?
>
> yes and no. in that commit, I automatically create n+1 device when
> loop device n is created, allergically was tested to be fine with
> casual usage of "losetup" and "mount -o loop".  However, there is a
> bug in that commit when loop.c was compiled as a module.  And when Al
> fixed it, he also removed that magic "n+1" trick.

As I said before, the reporter *tested* with Al's two patches
reverted, AND IT STILL FAILED. Your commit had to be reverted as well
to fix the problem.

> Nevertheless, yes, I'm guilty of introducing the new behavior.

It's not a behavior, it's a bug. Whether you reintroduce the n+1
inductive trick is immaterial to the problem at hand. loop.c needs to
populate 8 or max_loop devices upon init to maintain current behavior.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/