linux-kernel - Re: [PATCH]serial: make early_uart to use early_prarm instead of console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705211202.59817.bjorn.helgaas@hp.com>
Date:	Mon, 21 May 2007 12:02:59 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Gerd Hoffmann" <kraxel@...hat.com>, "Andi Kleen" <ak@...e.de>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"linux kernel mailing list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]serial: make early_uart to use early_prarm instead of console_initcall

On Monday 21 May 2007 11:36:58 am Yinghai Lu wrote:
> On 5/21/07, Bjorn Helgaas <bjorn.helgaas@...com> wrote:
> > > earlycon=uart,io,0x3f8,9600n8
> > > earlycon=uart,io,0x3f8,9600n8 console=tty0
> > > earlycon=uart,mmio,0xff5e0000,115200n8
> >
> > Why do we have to have a new "earlycon" argument?  Why can't we just
> > parse "console=uart" early?
> 
> with console=uart, you need to call early_serial_console_init
> explictly in your arch setup_arch to get early console.

Can't we just do:

  early_param("console", setup_early_console);

and have setup_early_console() ignore everything except "uart"?
 
> with console_initcall(early_uart_console_init), the early_uart_console
> will be called via console_init in start_kernel, init/main.c that is
> not real early console.

I agree that's too late.

Bjorn

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/