linux-kernel - Re: [PATCH] i386: fix early usage of atomic_add_return and local_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1179830248.12708.120.camel@chaos>
Date:	Tue, 22 May 2007 12:37:28 +0200
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andi Kleen <ak@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] i386: fix early usage of atomic_add_return and
	local_add_return on real i386

On Tue, 2007-05-22 at 12:34 +0200, Andi Kleen wrote:
> On Tuesday 22 May 2007 11:48, Thomas Gleixner wrote:
> > The check (boot_cpu_data.x86 == 3) in atomic_add_return() and
> > local_add_return() fails, when those operations are used before
> > boot_cpu_data is filled in.
> >
> > Change the check to (boot_cpu_data.x86 <= 3) to fix this.
> 
> That's a critical boot fix for 386, right?

Yup. Hit me with some debug option enabled, but might happen anywhere
else too.

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/