linux-kernel - Re: [PATCH -ak] Fix missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070522073935.GA8896@uranus.ravnborg.org>
Date:	Tue, 22 May 2007 09:39:35 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Andi Kleen <ak@...e.de>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -ak] Fix missing include

On Tue, May 22, 2007 at 09:28:15AM +0200, Thomas Gleixner wrote:
> On Tue, 2007-05-22 at 08:20 +0200, Andi Kleen wrote:
> > On Monday 21 May 2007 22:03, Thomas Gleixner wrote:
> > > ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
> > >
> > > explodes in various places due to missing defines of __cold. We can't
> > > rely on the assumption that linux/compiler.h is included magically
> > > before bug.h is included. Include it explicitely.
> > 
> > Hmm, somehow it worked here. Perhaps longer term it would be a good
> > idea to turn compiler.h into an -include
> 
> Might be not a bad idea. > 300 files include it directly and it's
> included from sched.h & co as well.

How about a file like:
include/linux/always_include.h

This file could then include autoconf.h + compiler.h
So we avoid an even longer gcc commandline.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/