linux-kernel - Re: [PATCH] UDF: possible usage of uninitialized variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070522113926.b7f1e690.akpm@linux-foundation.org>
Date:	Tue, 22 May 2007 11:39:26 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] UDF: possible usage of uninitialized variables

On Tue, 22 May 2007 21:52:23 +0400
Cyrill Gorcunov <gorcunov@...il.com> wrote:

> A few variables could be used without being explicitly initialized.
> Fixed.

Are you sure?  I'm expecting that this is a gcc mistake.

> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> ---
> 
> 
>  balloc.c |    6 +++++-
>  super.c  |    5 ++++-
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/balloc.c b/balloc.c
> index 4cec910..be37393 100644
> --- a/balloc.c
> +++ b/balloc.c

Please always use `patch -p1' form from the top-level directory.  This should
have been

--- a/fs/udf/balloc.c
+++ b/fs/udf/balloc.c

> @@ -744,7 +744,11 @@ static int udf_table_new_block(struct super_block * sb,
>  	uint32_t spread = 0xFFFFFFFF, nspread = 0xFFFFFFFF;
>  	uint32_t newblock = 0, adsize;
>  	uint32_t elen, goal_elen = 0;
> -	kernel_lb_addr eloc, goal_eloc;
> +	kernel_lb_addr eloc;
> +	kernel_lb_addr goal_eloc = {
> +		.logicalBlockNum = 0,
> +		.partitionReferenceNum = 0,
> +	};

	kernel_lb_addr goal_eloc = { };

is equivalent and sufficient.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/