linux-kernel - Re: any value to "NORET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705221616270.18792@localhost.localdomain>
Date:	Tue, 22 May 2007 16:17:48 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Krzysztof Halasa <khc@...waw.pl>
cc:	Adrian Bunk <bunk@...sta.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: any value to "NORET_TYPE" macro?

On Tue, 22 May 2007, Krzysztof Halasa wrote:

> Adrian Bunk <bunk@...sta.de> writes:
>
> >> no, i think you're thinking of the alternative ATTRIB_NORET macro.
> >> as you can read in my previous post, NORET_TYPE used to resolve to
> >> "__volatile__" for very old gcc.  so i think it's legitimately dead
> >> and can be ripped out.
> >
> > No doubt that it could be removed because it doesn't have any effect.
> >
> > But locking at the usages, it seems to have been used when people
> > thought it was what __noreturn now is, so replacing NORET_TYPE with
> > __noreturn might be a small optimization (but every NORET_TYPE should
> > be checked that it's actually correct).
>
> Actually it seems all the NORET_TYPEs are in fact (should be)
> __attribute__((noreturn)) (2.6.21):

that may be but, as i suggested earlier, that would get into guessing
what those developers were thinking, and i just didn't want to go
there.

the simple version of the patch is now in andrew's tree, and i'll
worry about the harder stuff next time.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/