linux-kernel - Current utrace breaks UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070522213831.GB10293@c2.user-mode-linux.org>
Date:	Tue, 22 May 2007 17:38:31 -0400
From:	Jeff Dike <jdike@...toit.com>
To:	Roland McGrath <roland@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Current utrace breaks UML

This chunk from linux-2.6-utrace.patch breaks PTRACE_SYSEMU, which UML
rather relies on.

@@ -514,9 +514,6 @@ syscall_trace_entry:
 	movl %esp, %eax
 	xorl %edx,%edx
 	call do_syscall_trace
-	cmpl $0, %eax
-	jne resume_userspace		# ret != 0 -> running under PTRACE_SYSEMU,
-					# so must skip actual syscall
 	movl PT_ORIG_EAX(%esp), %eax
 	cmpl $(nr_syscalls), %eax
 	jnae syscall_call

If the point of this patch was to completely remove ptrace support,
with later patches adding it back, then that chunk should be added
back in utrace-ptrace-compat.patch.

				Jeff

-- 
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/