linux-kernel - Re: [PATCH] ata: pata_platform: Disable prereset logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 May 2007 17:30:26 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Tejun Heo <htejun@...il.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: pata_platform: Disable prereset logic.

On Wed, May 23, 2007 at 10:07:08AM +0200, Tejun Heo wrote:
> Paul Mundt wrote:
> > On a number of boards the current prereset logic seems to misbehave:
> > 
> > scsi0 : pata_platform
> > ata1: PATA max PIO0 cmd 0xb06001f0 ctl 0xb06003f6 bmdma 0x00000000 irq 0
> > ata1: device not ready (errno=-19), forcing hardreset
> > ata1: BUG: prereset() requested invalid reset type
> > 
> > This triggers when there is no card inserted in the slot.
> > 
> > Simply disabling the prereset gets rid of this, and doesn't seem to cause
> > any problems for either PCMCIA or CF cards when they're actually present.
> 
> NACK.  The BUG printking needs fixing but you can't just kill
> prereset().  Did it work properly on 2.6.21.1?  Can you modify
> ata_wait_ready() such that it prints out the status value while waiting?
> 
ata_wait_ready() works fine, it reports 0xff immediately (and this is
what I would expect when there is no card inserted).

The board that exhibits this behaviour wasn't supported in the older
kernels, I can backport and test if it will be useful, though.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/