[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a781481a0705230137v4c8ba82fx263212a2958b55b9@mail.gmail.com>
Date: Wed, 23 May 2007 14:07:19 +0530
From: "Satyam Sharma" <satyam.sharma@...il.com>
To: "Krzysztof Halasa" <khc@...waw.pl>
Cc: "Robert P. J. Day" <rpjday@...dspring.com>,
"Adrian Bunk" <bunk@...sta.de>,
"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: any value to "NORET_TYPE" macro?
On 5/23/07, Krzysztof Halasa <khc@...waw.pl> wrote:
> "Robert P. J. Day" <rpjday@...dspring.com> writes:
>
> > that may be but, as i suggested earlier, that would get into guessing
> > what those developers were thinking, and i just didn't want to go
> > there.
>
> No guessing, I just checked it (though a second check wouldn't do
> any harm).
>
> > the simple version of the patch is now in andrew's tree, and i'll
> > worry about the harder stuff next time.
>
> The "next time" would be much harder as there would be no key for
> searching for these functions.
Krzysztof's absolutely right ... we don't want to lose the NORET_TYPE
annotations on all these functions before we switch them to
ATTRIB_NORET. And yes, _all_ of these NORET_TYPE's do want
to be ATTRIB_NORET (except for those that are double-annotated,
for those we can just get rid of the NORET_TYPE macro).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists