linux-kernel - Re: [RFC] LZO de/compression support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cefeab80705230703vdb3c414s250a61c4c2d70c51@mail.gmail.com>
Date:	Wed, 23 May 2007 19:33:36 +0530
From:	"Nitin Gupta" <nitingupta910@...il.com>
To:	"Michael-Luke Jones" <mlj28@....ac.uk>
Cc:	linux-kernel@...r.kernel.org,
	"Richard Purdie" <richard@...nedhand.com>, linux-mm-cc@...top.org
Subject: Re: [RFC] LZO de/compression support - take 3

On 5/23/07, Michael-Luke Jones <mlj28@....ac.uk> wrote:
>
> Fair enough. However, this rather important issue is pretty much
> undocumented (source code comments don't count)

If header file for public interface (<linux/lzo1x.h> documents about
'unsafe' vs. 'safe' then it should be enough.

> and Reiser4 is
> already using the lzo1x_decompress() function rather than the
> seemingly more appropriate lzo1x_decompress_safe() function...
>
> http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-
> rc2/2.6.22-rc2-mm1/broken-out/reiser4-use-lzo-library-functions.patch
>
> Perhaps a rename is in order:
> lzo1x_decompress() => lzo1x_decompress_unsafe()
> lzo1x_decompress_safe => lzo1x_decompress()
>

Or perhaps make reiserfs use _safe() instead - I think Richard has
already submitted patch for same.

- Nitin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/