linux-kernel - Re: [PATCH 2/2] make fbcon unregister when unloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1179881246.4638.13.camel@daplas>
Date:	Wed, 23 May 2007 08:47:26 +0800
From:	"Antonino A. Daplas" <adaplas@...il.com>
To:	Jesse Barnes <jesse.barnes@...el.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org,
	James Simmons <jsimmons@...tafluge.infradead.org>
Subject: Re: [PATCH 2/2] make fbcon unregister when unloaded

On Tue, 2007-05-22 at 15:14 -0700, Jesse Barnes wrote:
> On Tuesday, May 22, 2007 3:05 pm Randy Dunlap wrote:
> > On Tue, 22 May 2007 14:44:52 -0700 Jesse Barnes wrote:
> > > When unloaded, the fbcon driver should unregister itself from the
> > > VT subsystem using unbind_con_driver.  This patch makes it use the
> > > newly exported function to do just that.
> > >
> > > Signed-off-by:  Jesse Barnes <jesse.barnes@...el.com>
> > >
> > > diff -Napur -X /home/jbarnes/dontdiff --exclude=Makefile
> > > linux-2.6.22-rc2/drivers/video/console/fbcon.c
> > > linux-2.6.22-rc2-modesetting/drivers/video/console/fbcon.c ---
> > > linux-2.6.22-rc2/drivers/video/console/fbcon.c	2007-05-18
> > > 21:06:17.000000000 -0700 +++
> > > linux-2.6.22-rc2-modesetting/drivers/video/console/fbcon.c	2007-05-
> > >22 14:26:20.000000000 -0700 @@ -2937,6 +2937,21 @@ static int
> > > fbcon_mode_deleted(struct fb_ return found;
> > >  }
> > >
> > > +static int fbcon_fb_unbind(int idx)
> > > +{
> > > +	int i;
> > > +
> > > +        for (i = 0; i < MAX_NR_CONSOLES; i++) {
> > > +                /* Assure we do not unbind other drivers */
> > > +                if (idx == con2fb_map[i])
> > > +                        /* can be optimize to minimize multiple
> > > calls to +			   unbind_con_driver() */
> >
> > 			/*
> > 			 * can be optimized to minimize multiple calls
> > 			 * to unbind_con_driver()
> > 			 */
> >
> > > +                        unbind_con_driver(&fb_con, i, i, 0);
> > > +        }
> > > +
> > > +	return 0;
> > > +}
> >
> > Lots of whitespace mangling there (mostly spaces instead of tabs).
> 
> Oops, thanks for looking.  Somehow my emacs configuration broke and I 
> don't see this as readily as I used to.  If Antonio is ok with the 
> patch otherwise, I'll respin it with the cleanups.

This should be a lot safer than the previous patch. This is fine as long
as only a single driver is driving the console. For multiple drivers, it
will need the change that I promised weeks ago :-). (And I will work on
it soon).

Tony

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/