[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070523093119.e3a58fcc.kristen.c.accardi@intel.com>
Date: Wed, 23 May 2007 09:31:19 -0700
From: Kristen Carlson Accardi <kristen.c.accardi@...el.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: jeff@...zik.org, linux-ide@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
htejun@...il.com
Subject: Re: [patch 5/7] genhd: send async notification on media change
On Tue, 22 May 2007 14:12:11 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Wed, 9 May 2007 16:38:35 -0700
> Kristen Carlson Accardi <kristen.c.accardi@...el.com> wrote:
>
> > Send an uevent to user space to indicate that a media change event has occurred.
> >
> > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@...el.com>
> >
> > Index: 2.6-git/block/genhd.c
> > ===================================================================
> > --- 2.6-git.orig/block/genhd.c
> > +++ 2.6-git/block/genhd.c
> > @@ -643,6 +643,27 @@ struct seq_operations diskstats_op = {
> > .show = diskstats_show
> > };
> >
> > +static void media_change_notify_thread(struct work_struct *work)
> > +{
> > + struct gendisk *gd = container_of(work, struct gendisk, async_notify);
> > + char event[] = "MEDIA_CHANGE=1";
> > + char *envp[] = { event, NULL };
> > +
> > + /*
> > + * set enviroment vars to indicate which event this is for
> > + * so that user space will know to go check the media status.
> > + */
> > + kobject_uevent_env(&gd->kobj, KOBJ_CHANGE, envp);
> > + put_device(gd->driverfs_dev);
> > +}
> > +
> > +void genhd_media_change_notify(struct gendisk *disk)
> > +{
> > + get_device(disk->driverfs_dev);
> > + schedule_work(&disk->async_notify);
> > +}
> > +EXPORT_SYMBOL_GPL(genhd_media_change_notify);
> > +
> > struct gendisk *alloc_disk(int minors)
> > {
> > return alloc_disk_node(minors, -1);
> > @@ -672,6 +693,8 @@ struct gendisk *alloc_disk_node(int mino
> > kobj_set_kset_s(disk,block_subsys);
> > kobject_init(&disk->kobj);
> > rand_initialize_disk(disk);
> > + INIT_WORK(&disk->async_notify,
> > + media_change_notify_thread);
> > }
> > return disk;
>
> Why does this do a schedule_work() rather than calling kobject_uevent_env()
> directly?
>
Because it is called at Interrupt time.
Kristen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists