linux-kernel - Re: [PATCH] CDROM: replace jiffies busyloop with msleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46549825.6040500@gmail.com>
Date:	Wed, 23 May 2007 21:38:13 +0200
From:	Rene Herman <rene.herman@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Jeff Garzik <jeff@...zik.org>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH] CDROM: replace jiffies busyloop with msleep

On 05/23/2007 09:34 PM, Alan Cox wrote:

>> driver was snappy in that regard. When I replaced our sleeping loop with a 
>> busy-wait same as the original the snappyness returned and moreover, reading 
>> the TOC from the CD went from something close to a minute to approximately a 
>> second. Thought that minute was just because I was dealing with an old junk 
>> 1-speed drive...
> 
> It happens. If you want to be fairer you can check need_resched in the
> loop so that you still share the CPU fairly with other users.

Thanks for the tip -- I'll do this.

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/