linux-kernel - Re: any value to "NORET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m33b1mz7sz.fsf@maximus.localdomain>
Date:	Thu, 24 May 2007 15:10:20 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	"Satyam Sharma" <satyam.sharma@...il.com>
Cc:	"Robert P. J. Day" <rpjday@...dspring.com>,
	"Adrian Bunk" <bunk@...sta.de>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: any value to "NORET_TYPE" macro?

"Satyam Sharma" <satyam.sharma@...il.com> writes:

> Actually there's another thing :-) The __attribute__((xxx)) must go with the
> function _declarations_ (and not the implementations/definitions). I noticed
> after my previous mail that most of the double annotations are actually in
> the case of the _declarations_ of these non-returning functions, whereas
> most of the single-occurrences of NORET_TYPE were in the function
> definitions, which means your patch that simply got rid of NORET_TYPE
> actually ended up doing exactly the right thing that we wanted :-)

Only half of it. Half of right thing is (here) a bad thing.

NORET_TYPE does not do any harm.
Removing it removes pointers to attrib((noreturn)) candidates.
Simple.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/