linux-kernel - Re: [PATCH 4/7] SMP: Implement on_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46559794.50208@qumranet.com>
Date:	Thu, 24 May 2007 16:48:04 +0300
From:	Avi Kivity <avi@...ranet.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	shaohua.li@...el.com, lhcs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 4/7] SMP: Implement on_one_cpu()

Roland Dreier wrote:
> I don't see any documented restrictions about preemption being
> disabled when this function is called, but...
>
>  > +int on_one_cpu(int cpu, void (*func) (void *info), void *info,
>  > +	       int retry, int wait)
>  > +{
>  > +	int ret;
>  > +	int this_cpu;
>  > +
>  > +	this_cpu = get_cpu();
>
> what if a preempt and reschedule to a different CPU happens right
> here, after this_cpu is set?
>
>  > +	if (this_cpu == cpu) {
>   

get_cpu() disables preemption (the return value would be meaningless 
otherwise).


-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/