linux-kernel - Re: [patch] use POSIX equality test in check-lxdialog.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0705241752491.31549@yvahk01.tjqt.qr>
Date:	Thu, 24 May 2007 17:53:54 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Mike Frysinger <vapier@...too.org>
cc:	sam@...nborg.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] use POSIX equality test in check-lxdialog.sh


On May 23 2007 21:37, Mike Frysinger wrote:

>The "==" operator is not in POSIX, so use -eq instead.

Apart from that, == is for strings, -eq is for numbers,
so that wrong variable content can be caught
("$x" -eq 123 where x=123foo throws an error).

So yes, the patch is good.

	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/