linux-kernel - Re: [patch 00/69] -stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.98.0705240854250.26602@woody.linux-foundation.org>
Date:	Thu, 24 May 2007 09:16:10 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Romano Giannetti <romanol@...omillas.es>
cc:	Chris Wright <chrisw@...s-sol.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable@...nel.org, Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	"Rafael J. Wysocki" <rjw@...k.pl>, Pavel Machek <pavel@....cz>
Subject: Re: [patch 00/69] -stable review


On Thu, 24 May 2007, Romano Giannetti wrote:
> 
> I discovered that SysRq-t works during the pause. So I pressed it more
> or less halfway the pause; the full result is here:
> http://www.dea.icai.upcomillas.es/romano/linux/info/dmesg-resume.txt
> 
> It seems that most of the tasks are in
> 
> [<c0138931>] refrigerator+0x41/0x60

Yeah, but the interesting one is this pair:

  events/0      R running     0     4      1 (L-TLB)

  sleep.sh      D 0000014F     0  5798   5789 (NOTLB)
  Call Trace:
   [<c01d3c01>] kobject_uevent_env+0x3a1/0x4a0
   [<c02d8509>] wait_for_completion+0x79/0xb0
   [<c0116640>] default_wake_function+0x0/0x10
   [<c0238a08>] _request_firmware+0x1c8/0x310
   [<c0238bef>] request_firmware+0xf/0x20
   [<e0a35d5d>] pcmcia_bus_match+0x28d/0x3c0 [pcmcia]
   [<c02864a7>] netlink_broadcast+0x1f7/0x310
   [<c0233d74>] driver_probe_device+0x34/0xc0
   [<c02d79ee>] klist_next+0x4e/0xa0
   [<c0233014>] bus_for_each_drv+0x44/0x70
   [<c0233eba>] device_attach+0x7a/0x80
   [<c0233e00>] __device_attach+0x0/0x10
   [<c0232f56>] bus_attach_device+0x26/0x60
   [<c0231d06>] device_add+0x5e6/0x6e0
   [<c01d350f>] kobject_init+0x2f/0x50
   [<e0a360f5>] pcmcia_device_add+0x185/0x220 [pcmcia]
   [<e0a36261>] pcmcia_card_add+0xa1/0xc0 [pcmcia]
   [<e0913900>] ti12xx_power_hook+0x180/0x1d0 [yenta_socket]
   [<e0a36300>] ds_event+0x80/0xb0 [pcmcia]
   [<e0967359>] send_event+0x39/0x70 [pcmcia_core]
   [<e09677b6>] socket_insert+0x86/0xe0 [pcmcia_core]
   [<e0967c2b>] pcmcia_socket_dev_resume+0x7b/0x90 [pcmcia_core]
   [<c01e135f>] pci_device_resume+0x1f/0x60
   [<c023815f>] resume_device+0x5f/0xf0

ie we have a deadlock because resume wants to do that firmware request,
but the event daemon is apparently spinning like mad. 

And yes, request_firmware() has a "loading_timeout" in seconds.  And
it's 60. So that explains your pause right there!

It might be some unfortunate interaction with process freezing (my
favorite whipping boy), but it could also be something else.  I suspect
we should treat suspend/resume as a bootup event, and not allow execve()
for that case at all. Right now we have:

        retval = -EPERM;
        if (current->fs->root)
                retval = kernel_execve(sub_info->path,
                                sub_info->argv, sub_info->envp);

in kernel/kmod.c, and that "current->fs->root" thing basically protects
us from trying to run a user-mode helper early in the boot sequence, but
we might want to add a conditional like "&& !resuming" to that test..

		Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/