linux-kernel - Re: any value to "NORET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705241239560.10926@localhost.localdomain>
Date:	Thu, 24 May 2007 12:43:07 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Satyam Sharma <satyam.sharma@...il.com>
cc:	Krzysztof Halasa <khc@...waw.pl>, Adrian Bunk <bunk@...sta.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: any value to "NORET_TYPE" macro?

On Wed, 23 May 2007, Satyam Sharma wrote:

> Actually there's another thing :-) The __attribute__((xxx)) must go
> with the function _declarations_ (and not the
> implementations/definitions).

that's not true, AFAICT.  the pattern seems to be that, in the case of
declarations, attributes go at the end, as in:

arch/sparc/boot/btfixupprep.c:void fatal(void) __attribute__((noreturn));

while in actual definitions, they typically go after the return type,
as in arch/arm/kernel/traps.c:

void __attribute__((noreturn)) __bug(const char *file, int line)
{
        printk(KERN_CRIT"kernel BUG at %s:%d!\n", file, line);
        *(int *)0 = 0;

        /* Avoid "noreturn function does return" */
        for (;;);
}

  is that the standard that most people use?  if it is, i can use that
standard for the cleanup.

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/